Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mapbox Style support #34

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

panaaj
Copy link
Member

@panaaj panaaj commented Sep 27, 2024

This PR adds support for mapbox style json files placed in the folder paths configured in the plugin settings.
MapBox styles are served from the path /chart-styles.

It also improves v2 Resources API support by serving map tiles from a path that is not under resources/charts (/chart-tiles).

Examples:

{
   ...
   "url": "/chart-tiles/<chart_identifier>/{z}/{x}/{y}"
},
{
   ...
   "url": "/chart-styles/<mapstyle>.json"
}

Added option to store Mapbox access token which is applied to all Mapbox Style JSN urls.
image

Removing the use of a shared path aligns better with multi-provider support.
Tile paths have a fully qualified path, remove use of relative path.
@panaaj panaaj added enhancement New feature or request feature labels Sep 27, 2024
@panaaj panaaj changed the title Mapbox Style support WIP: Mapbox Style support Sep 27, 2024
@panaaj panaaj requested review from tkurki and sbender9 October 2, 2024 06:46
@panaaj panaaj changed the title WIP: Mapbox Style support Add Mapbox Style support Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant